Update best_practices.rst #12617
Merged
Update best_practices.rst #12617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amine-betari thanks! This is correct ... but the reword implies that you can access to ALL public services, and that's not true. So ... what if reword this again and say something like this: |
|
@javiereguiluz done thank's. I thought we could access to all public services |
javiereguiluz
added
DependencyInjection
Status: Reviewed
and removed
Status: Needs Review
labels
javiereguiluz
approved these changes
Nov 12, 2019
OskarStark
approved these changes
Nov 12, 2019
|
Thank you @amine-betari. |
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2019
This PR was squashed before being merged into the 4.3 branch (closes #12617). Discussion ---------- Update best_practices.rst // there is a public "router" service in the container $router = $this->container->get('router'); // this will not Work: MailLogger is a private service $mailLogger = $this->container->get(MailLogger::class); Commits ------- fcddead Update best_practices.rst
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2019
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2019
* 4.3: fix linelength. refs #12617
OskarStark
added a commit
that referenced
this pull request
Nov 12, 2019
* 4.4: fix linelength. refs #12617 Update best_practices.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// there is a public "router" service in the container
$router = $this->container->get('router');
// this will not Work: MailLogger is a private service
$mailLogger = $this->container->get(MailLogger::class);